Update nexus link converter #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Aug 28, 2024
rodrigozhou
force-pushed
the
rodrigozhou/fix-nexus-link-converter
branch
from
f945868 to
e1499aa
Compare
rodrigozhou
force-pushed
the
rodrigozhou/fix-nexus-link-converter
branch
from
e1499aa to
2f42c84
Compare
lina-temporal
pushed a commit
that referenced
this pull request
Aug 28, 2024
## What changed? <!-- Describe what has changed in this PR --> Update nexus link converter ## Why? <!-- Tell your future self why have you made these changes --> Sync with code in SDK. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
dnr
pushed a commit
that referenced
this pull request
Oct 4, 2024
## What changed? <!-- Describe what has changed in this PR --> Update nexus link converter ## Why? <!-- Tell your future self why have you made these changes --> Sync with code in SDK. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update nexus link converter
Why?
Sync with code in SDK.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?